Skip to content

try pyo3 branch without lazy errors #1675

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

try pyo3 branch without lazy errors #1675

wants to merge 1 commit into from

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Testing out PyO3/pyo3#4859, I was just curious to see how much this might affect perf...

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 26, 2025

CodSpeed Performance Report

Merging #1675 will degrade performances by 11.3%

Comparing dh/try-pyo3-eager-err (0ee4df2) with main (6c936de)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 154 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ test_raise_error_value_error 36.8 µs 41.5 µs -11.3%
⚡ test_json_direct_list_int 147.8 µs 134.1 µs +10.23%
⚡ test_ser_list_of_lists 1.4 ms 1.2 ms +11.44%

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidhewitt